CodeByZach / pace

Automatically add a progress bar to your site.
https://codebyzach.github.io/pace/
MIT License
15.65k stars 1.91k forks source link

Breaks WebSocket #496

Closed dannysmc95 closed 3 months ago

dannysmc95 commented 4 years ago

Hi there,

It looks like pace does not properly manage WebSocket connections, and therefore attempts to proxy it, and then breaks it, this has been tested using AWS Chime SDK, and I can see that the connections fail when Pace is being used.

Can you either create an option to ignore WebSockets or find a fix for the issue so we can patch it.

Thanks in advance, Danny

EmaGht commented 3 years ago

Either you try with the option "trackWebSocket = false" (which didn't work for me)

Or you take a pace version with all websocket's reference removed from the source code that i just published in my company's private repository:

https://www.npmjs.com/package/@esfaenza/pace

dannysmc95 commented 3 years ago

Hi, yes no worries, we had to do the same, I was just noting it for the developers to fix it, but looks like this project is dead.