search

CodeByZach / pace

Automatically add a progress bar to your site.
https://codebyzach.github.io/pace/
MIT License
15.68k stars 1.9k forks source link

Ownership #505

Closed FranDias closed 3 years ago

FranDias commented 3 years ago

In @a2intl's pursuit of getting https://github.com/HubSpot/pace/pull/504 merged he reached out and mentioned @EatBreatheCode's fork as being active. We're clearly not. @eatbreathecode would you be interested in ownership of this project?

CodeByZach commented 3 years ago

I would. Let me know if anything is needed from my end.

FranDias commented 3 years ago

Sweet, thank you for your contributions.

CodeByZach commented 3 years ago

My pleasure! Funny aside, I'm currently working on a huge project which includes our integration with your CRM. Not sure if you're actively involved in it's development over at HubSpot, but the API has been pretty rock-solid comparative to some others I won't mention :)

FranDias commented 3 years ago

@EatBreatheCode Ran into an issue - EatBreatheCode/pace already exists so I can't transfer it while your fork exists with that name. I can transfer when that's renamed.

Ha, Awesome! I worked on the CRM FE for a little over 4 years, work on a slightly different team now but I'll pass the feedback along :)

CodeByZach commented 3 years ago

I'll rename to something like EatBreatheCode/_pace for now, stand by.

CodeByZach commented 3 years ago

Done.

CodeByZach commented 3 years ago
image
FranDias commented 3 years ago

That was from me fumbling around trying to figure out how to transfer ownership to you without having to delete your branch (accidentally clicked successor).

Error that's now coming up is that since you have a fork in the, now, frandias/pace network (projects must go org > person > *) I can't transfer. I looked around and it appears github doesn't allow you to just remove the fork source.

My current thought is for you to make a PR with master merged with the ours strategy to suppress conflicts and then, upon merging, delete your fork. I understand that this isn't an ideal solution as you've tagged different releases. I'm open to any suggestions on how to move forward.

CodeByZach commented 3 years ago

Could we not just try removing the forked relationship? Making it just another repo.

FranDias commented 3 years ago

From what I understand you'd need to contact github support for that.

CodeByZach commented 3 years ago

I have an idea...

FranDias commented 3 years ago

holds EatBreatheCode's kombucha

CodeByZach commented 3 years ago

LOL, almost done!

CodeByZach commented 3 years ago

Try now!

FranDias commented 3 years ago

Transferred 😄

Thanks @a2intl for doing the leg work on this.

CodeByZach commented 3 years ago

Swamped with work at the moment, but boy are there a lot of pull requests to close this weekend! Thanks again for your awesome help.