search

CodeCabin / wp-google-maps

WP Google Maps
16 stars 12 forks source link

[Feature request] don't remove duplicate markers in different maps #1039

Closed nicoletta-maia closed 1 year ago

nicoletta-maia commented 1 year ago

Remove duplicate markers button deletes markers even if they belong to different maps; in our website several maps have some markers in common and we would not want them to be considered duplicates. Could you consider this change?

I would suggest changing here and here the GROUP BY clause to: GROUP BY map_id, lat, lng, address, title, link, description

DylanCodeCabin commented 1 year ago

@nicoletta-maia Thank you for bringing this to our attention!

I can definitely see how this additional condition would be helpful. Originally the logic was developed to remove duplicates, regardless of the Map they belong to, but in hindsight, we should have thought about this combination as well.

I have flagged this as a bug, and it will be resolved in our next update.

DylanCodeCabin commented 1 year ago

This has been released in a pre-release, which will be deployed in the next week