CodeCabin / wp-google-maps

WP Google Maps
16 stars 12 forks source link

PRO :: CategoryTree::createInstance() #984

Closed shazahm1 closed 2 years ago

shazahm1 commented 4 years ago

The filter does not pass the $map attribute. Currently, it is:

        if($override = apply_filters('wpgmza_create_WPGMZA\\CategoryTree', $override))
            return $override;

Please consider passing $map too. Like this:

        if($override = apply_filters('wpgmza_create_WPGMZA\\CategoryTree', $override, $map))
            return $override;

Why? This way the map object can be checked to see if an integration is active for the map and selectively override the category tree.

DylanCodeCabin commented 2 years ago

Thank you for the request, I am sorry it has taken us this long to get back to you.

I am currently cleaning up this repo so that we can focus on opening communication with contributors moving forward.

I need to confirm where this is in our working copy of V9 which is being developed at the moment. This issue will likely be closed and moved to the internal repo, where it will be released as part of the upcoming release.

You can learn more about the future of this repo here:

DylanCodeCabin commented 2 years ago

This has been moved to an internal repo, and my team will ensure this is resolved as part of the V9 build

shazahm1 commented 2 years ago

@DylanCodeCabin

Did the $map paremeter for the filter parameter make into the upcoming v9 release?

DylanCodeCabin commented 2 years ago

@shazahm1

Yes, I'm happy to confirm it has been included in the release that will be going out, ideally, later today!