search

CodeCatz / TrackCat

A tool for tracking the progress of the kittens (and cat{s,z}) in our CodeCatz meetup group
MIT License
5 stars 14 forks source link

Made members page dynamic #130

Closed mojcas closed 9 years ago

mojcas commented 9 years ago

Replaced static contents of members page with dynamic

goranche commented 9 years ago

Happy now?

I wouldn't go as far as saying that... I was quite happy before as well :stuck_out_tongue_winking_eye:

you know what might be a good thing to add (as long as you already have the if structure), maybe add different classes to the

  • tags for different classes of members... it will make it easier to create design cues to differentiate the members... :smile:

    • mojcas commented 9 years ago

    ok :smile_cat:

    goranche commented 9 years ago

    @mojcas do you know how classes are added to HTML tags? if not, try searching for "HTML tag class" (and of course, if you still have problems, we'll help :wink: )

    mojcas commented 9 years ago

    I mean, should I create new classes, or what classes should I use? I'm not so good on design, etc. :wink:

    goranche commented 9 years ago

    you can define your own ones, maybe copy them from the model (but use lower case), just so someone can address them from the CSS later on

    mojcas commented 9 years ago

    @goranche classes added.. but they don't seem to do much.. Still happy? :smile_cat: What else? Now we wait for other peers review? In the meanwhile, caan I create another branch, to continue? :confused:

    goranche commented 9 years ago

    to continue

    depends on what "to continue" means to you... if it depends on the code in this PR, then I don't recommend it, because what if this code isn't merged into the repository, what if you need to change it some more? but in general, the answer is yes, you could do that if you mean work on something unrelated, sure

    mojcas commented 9 years ago

    unrelated yes, the navigation .. Navigation bar "folds" at certain widths :wink:

    mojcas commented 9 years ago

    It is mostly unrelated, just one wee bit of a problem.. Both pull requests updating static/css/style.css .. Can this be merged? Thanks!

    goranche commented 9 years ago

    not sure what you mean by "can this be merged"...

    if nothing else, when on of the PRs is accepted, you'll have to make sure the other PR will have the same changes applied on it as well (sync with upstream and master)... this will make sure the changes are merged, yes

    ghost commented 9 years ago

    Tested this, works good with me; so as far as I am concerned our next step is to make a new issue: tasks.html. So instead of going to the members github account, you would be redirected to a page inside the webpage, which would show which tasks or projects a clicked member is assigned to.

    anuschka commented 9 years ago

    The profile_picture does not display for each active member (I added a picture for each user in the DB).

    mojcas commented 9 years ago

    @anuschka can you check right click on the picture and "Copy Image Location"? Also, when you add a picture in the DB, how you add it? Try like this, it works for me.. userprofile

    anuschka commented 9 years ago

    @mojcas I did exactly like you said and created the exact user like you did and still no picture. I select a picture from my local drive and add to the profile picture in the admin.

    mojcas commented 9 years ago

    @anuschka can you check right click on the picture and "Copy Image Location", paste it here?

    anuschka commented 9 years ago

    @mojcas : Your PR is working great and the pictures are showing perfectly :+1: