CodeCatz / TrackCat

A tool for tracking the progress of the kittens (and cat{s,z}) in our CodeCatz meetup group

MIT License

5 stars 14 forks source link

added member page in dynamic member profile template #139

Closed PettraV closed 9 years ago

PettraV commented 9 years ago

see http://127.0.0.1:8000/member_page/

138

added view in view.py - any suggestions how to include id, as this would be the best reference? added member_page.html - link to from members page is required modified urls

Thank you

PettraV commented 9 years ago

I changed all member_profile names to member-profile and it seems it does not work. one of my errors are invalid syntax (views.py, line 47) due to the dash/underscore change...What is actually wrong member_profile underscore in the name? Please advise how to resolve this

goranche commented 9 years ago

What is actually wrong member_profile underscore in the name?

it's ugly, especially in the case where you were mixing underscores with dashes... and given that it's in a URL, dashes are more "user-friendly"... regarding the errors: don't know, but I'm pretty sure there is a very clear error message that explains it all

goranche commented 9 years ago

@PettraV you do know, that not all the "member-page" in these files have to be the same, right? in urls, one of the parameter is what is recognised in the URL when using the app, and the other (where the syntax error is, because python doesn't allow dashes in method names) is a method name, that is called... it might be the same, but doesn't need to be

PettraV commented 9 years ago

Thx for the tip, i truly appreciate all your help and dedication!!! My problem problem for the past weeks and following months is that I am very limited with time and I would rather resolve dynamic urls & img in template in that hour that I still have and leave member_profile as it is, as the works. A compromise?

goranche commented 9 years ago

deadlines don't compromise :wink:

PettraV commented 9 years ago

but I just do not see 'ugly' as enough strong argument at this point :) and in my opinion I am adjusted with the project as I followed Livke's system with project_detail name :D

goranche commented 9 years ago

good for you :+1:

ialja commented 9 years ago

@PettraV There are other things that should be fixed before we can merge this PR. Less arguing, more following comments :stuck_out_tongue:

mojcas commented 9 years ago

@PettraV we can do it together. :tropical_fish: I am trying to work with these branches, still learning, but I have fixed this in my master, see https://github.com/mojcas/TrackCat/compare/CodeCatz:master...master I was struggling (same as you), as it seems it does not work, when the link contains member name (string), but I guess we can use the id.. check it out. Look at

web/templates/pages/members.html
web/templates/pages/member_page.html (link to the image)
web/urls.py
web/views.py

Lets get this fixed and continue with other things. :smile_cat:

PettraV commented 9 years ago

@mojcas you nailed it and finish the job, thank you! I used the code from #143

ialja commented 9 years ago

Closing this - it's getting old and outdated, and the comments haven't been addressed.