CodeCatz / TrackCat

A tool for tracking the progress of the kittens (and cat{s,z}) in our CodeCatz meetup group
MIT License
5 stars 14 forks source link

Navigation #140

Closed anuschka closed 9 years ago

anuschka commented 9 years ago

Addressed issue #75 and included login/logout option in the navigation.

goranche commented 9 years ago

fix indentation

goranche commented 9 years ago

@anuschka is the "Sign in" option supposed to change to "Sign out" when signed in?

anuschka commented 9 years ago

@goranche You are totally right and I am trying to figure out why it does not change to "Hi, name" with a drop down to sign out on the index.html page but it does on the other pages. Any hints?

anuschka commented 9 years ago

Found the bugger :smile_cat: in views.py.

def index(request): return render_to_response('pages/index.html',{},context_instance=RequestContext(request))

ghost commented 9 years ago

Looks good to me! We just need to do something with the front picture (and this does not refer to the exact picture groupmeet.jpg, that's just and example we all know needs to be changes :))

PettraV commented 9 years ago

no comments, just congrats :+1: :)

ialja commented 9 years ago

Might be just me, but I'm having issues reading the links (very poor contrast). Also, why are they scattered all over the place, randomly (mis)aligned? The login/logout now works, but why is in a different color than other links?

screen shot 2015-02-16 at 10 51 12

ercchy commented 9 years ago

Sorry, wrong button! :)

ialja commented 9 years ago

@anuschka You cannot make design changes that break the rest of the page (Catz lost their heads in the pic due to the change, the big TrackCat header is now floating in mid-air :disappointed:). Well, you can break stuff this way, but there's no way we're merging that :wink:

Also, we're not happy with you copying the positioning of the items from the Code Week website. That positioning had its reasons that cannot be transferred to TrackCat. If you want to improve the navigation, start by thinking what's needed where, and design a layout that makes sense for your project.

Closing this PR, I'd suggest you start fresh with a layout and design that's made for TrackCat.

screen shot 2015-02-17 at 10 18 39

anuschka commented 9 years ago

It was a good learning experience :books: