Closed anuschka closed 9 years ago
@anuschka please consider updates in UserProfile made in PR #167 as there some fields were removed, for example UserProfile 'user', 'fullname', 'githubuser', since these fields are already part of Django User model, and are being duplicated unnecessarily in UserProfile model.
Ok, lets figure out the order in which to merge these two PR's.
I can easily close mine and create it again.
But can we really remove these fields from the UserProfile model? When I look into the admin I can see only User, Provider, UID and Extradata provided by Github authentication which we use....
@ercchy told me about this last Wed :+1: UserProfile as per relations, is kind of an "extension" of User (Django object), which has already what we need... for example, it has: username, first_name, last_name, email.. I think we can see it here: https://docs.djangoproject.com/en/1.7/ref/contrib/auth/
That's not a problem, updating admin.py can be part of refactoring of UserProfile. I'll merge this and you can move the conversation to the Issue.
Addressed #145.