search

CodeCatz / TrackCat

A tool for tracking the progress of the kittens (and cat{s,z}) in our CodeCatz meetup group
MIT License
5 stars 14 forks source link

Create UserProfile when User first logs in #221

Closed mojcas closed 9 years ago

mojcas commented 9 years ago

Create UserProfile when User first logs in; change model to default activity status=KITTEN (no LAZY cats here :) ) Addresses issue #216

anuschka commented 9 years ago

:+1:

mojcas commented 9 years ago

When user logs in, user object is created, but no user profile exists yet, so member page doesn't have anything to display. I guess the question is, do we want user profile be created withI new user, or not? Why would anyone sign in, and not be a member? I though assigning a special kitten default activity level for new users would be good.. Maybe I am missing something.

ialja commented 9 years ago

It's a good idea to create a user profile object for each new user. Once TrackCat goes public, ANYONE in the world (incl. spammers and trolls) will be able to click the "Sign in with GitHub", so I'm not sure you want that anyone to be automatically be displayed on the page.

"Why would anyone sign in, and not be a member?" - because they can. And if they have rights to edit stuff, they will. Because they can. It's your job to prevent random users from making a mess out of your website.

mojcas commented 9 years ago

I have removed displaying KITTEN from Members page, and removed activity status from form so members can not change it themselves, but can still edit and update their profile.. Only Django admin can update activity status.

mojcas commented 9 years ago

Another thing I found, is to check for permissions of the user.. Only users with permissions can add new project, task, or change them...

livike commented 9 years ago

The new create/add/delete permission change is cool and works fine.

Also the Userprofile creation is working, but maybe after the first login would be nice to redirect to some welcome message, to prom them to fill in their profile or a message that a staff member will review their membership...

ialja commented 9 years ago

@livike Do add that suggestion to Issues!