CodeChain-io / codechain-sdk-go

Go Software Development Kit for CodeChain
5 stars 6 forks source link

Change strings to []byte #28

Closed cubismic closed 5 years ago

cubismic commented 5 years ago

Current implementation uses string a lot to follow the types of codechain-rpc-js, codechain-primitives-js.

But Golang encourages to use byte slice rather than string for many reasons.

So most of the string types in this repository should be changed to []byte

cubismic commented 5 years ago

These files contain functions that gets or returns string

majecty commented 5 years ago

@gurrpi You can try this issue.

baumstern commented 5 years ago

@gurrpi You can try this issue.

@majecty Thanks for your considering. I'll take care of this. :)