search

CodeChain-io / codechain-sdk-go

Go Software Development Kit for CodeChain
5 stars 6 forks source link

Use custom JSON marshal instead of object duplication #54

Open cubismic opened 4 years ago

cubismic commented 4 years ago

Currently, some of the Transaction-related objects have two forms, which implement normal type and for marshaling.

https://github.com/CodeChain-io/codechain-sdk-go/blob/6ad3e76c4dfba22b0867764b8c67500dce7518d2/core/transaction/signedTransaction.go#L11-L17 https://github.com/CodeChain-io/codechain-sdk-go/blob/6ad3e76c4dfba22b0867764b8c67500dce7518d2/core/transaction/signedTransaction.go#L19-L25

This implementation is from codechain-sdk-js. But since golang can implement custom marshaling function (link1) (link2), I think duplication of the objects is unnecessary.

cubismic commented 4 years ago

This is related to https://github.com/CodeChain-io/codechain-sdk-go/issues/53

cubismic commented 4 years ago

63