search

CodeChefVIT / OAuth-Pro

REST APIs for OAuth using LinkedIn, GitHub, Google and Facebook.
MIT License
10 stars 8 forks source link

Remove the clientId and client secret from Node.js/config/passport-setup.js and put it in an ENV file #16

Closed jugaldb closed 4 years ago

jugaldb commented 4 years ago

Currently the Google Client ID and Client Secret are in the code itself and that is not a good practice, remove them and put it in an .env file

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.77. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

edilson commented 4 years ago

@jugaldb could I work on this one?

jugaldb commented 4 years ago

@SEdilson This is currently a work in progress https://github.com/CodeChefVIT/OAuth-Pro/pull/19

If it has no updates, we will assign it to you.

DiptoChakrabarty commented 4 years ago

@rvjain0510 are you going to continue on this or else @SEdilson can pick it up from here

akshatvg commented 4 years ago

Due to no follow back for a while by the original developer, I’ll assign you @SEdilson ✌🏻

edilson commented 4 years ago

Hey @akshatvg, as requested here's the PR #23 to solve this issue. Thanks for letting me contribute.

jugaldb commented 4 years ago

PR merged, closing the issue thanks @SEdilson