BUG: CLI stop infinite loop - Githubissues

CodeClimbersIO / cli

The cli for the project

MIT License

13 stars 11 forks source link

BUG: CLI stop infinite loop #158

Closed Tanner-Scadden closed 2 months ago

Tanner-Scadden commented 2 months ago

The Pull Request is ready

[x] all github actions are passing
[x] only a single issue was worked on
[ ] fixes #
[x] the branch follows the naming schema issue-123-enable-x-does-not-disable-y
[x] the pull request has a sensible title

Intention

With this change I intend to...

Stopping was putting the cli into an infinite loop.
I don't think we should be disabling startup if they stop it, so I removed the startup service from being used here.

Review Points

Please take extra care reviewing...

The code follows best practices

[x] duplicate code has been extracted where possible
[x] issues for follow-up tasks have been created
[x] tests have been written for any new functionality
[x] there is no any type used
[x] texts have been checked for grammar and spelling issues

Notes

rphovley commented 2 months ago

Yeah, let me double check this stops the behavior but agreed that it would be best if this just stopped the running server and not also disable it. That's what startup:disable is for