CodeCombiner / native-android

GC Native Android
GNU General Public License v3.0
3 stars 1 forks source link

Remove empty spaces and backslashes for all plugins #71

Closed vivekb91 closed 6 years ago

vivekb91 commented 6 years ago

Reference #63

CodeCombiner commented 6 years ago

As we talk before backslashes should be present, is that correct?

rampr commented 6 years ago

Yes, backslashes should be present for content that has only numbers. Backslashes make them get interpreted as strings instead of number/float.

CodeCombiner commented 6 years ago

Please approve the list of plugins to be reviewed:

    "adventuremap": "git@github.com:hashcube/adventuremap.git#v2.4.11",
    "amazonads": "git@github.com:CodeCombiner/amazonads.git#master",
    "billing": "git@github.com:hashcube/billing.git#v4.3.11",
    "crashlytics": "git@github.com:CodeCombiner/crashlytics.git#master",
    "devkit-core": "https://github.com/CodeCombiner/devkit-core#hc",
    "devkithelper": "git@github.com:hashcube/devkithelper.git#v3.0.7",
    "facebook": "git@github.com:CodeCombiner/facebook.git#master",
    "firebase": "git@github.com:CodeCombiner/firebase.git#master",
    "flurry": "git@github.com:CodeCombiner/flurry.git#master",
    "freshchat": "git@github.com:CodeCombiner/freshchat.git#master",
    "gamecenter": "git@github.com:hashcube/gamecenter.git#v1.0.4",
    "gamecircle": "git@github.com:CodeCombiner/gamecircle.git#master",
    "gameplay": "git@github.com:CodeCombiner/gameplay.git#master",
    "ironsource": "git@github.com:CodeCombiner/ironsource.git#master",
    "kochava": "git@github.com:CodeCombiner/kochava.git#master",
    "localnotify": "git@github.com:hashcube/localnotify.git#v2.2.8",
    "onesignal": "git@github.com:CodeCombiner/onesignal.git#master",
    "utils": "git@github.com:CodeCombiner/utils.git#master"
CodeCombiner commented 6 years ago

PRs related to #71 Remove empty spaces and backslashes https://github.com/hashcube/facebook/pull/25 https://github.com/hashcube/kochava/pull/9 https://github.com/hashcube/utils/pull/19

rampr commented 6 years ago

The plugins list is correct @CodeCombiner