search

CodeConnoisseur74 / pdi-to-do-app

1 stars 0 forks source link

Fixes for datetime branch #9

Open CodeConnoisseur74 opened 1 year ago

CodeConnoisseur74 commented 1 year ago

@bbelderbos Fixes as requested. While True worked. Now the app accepts the dates and throws the message to user that past dates are not accepted.

SQLModel.metadata.drop_all(engine) I used to dekete the past tables no longer compatible with the fixes I made.

I searched google using: how to delete or refresh tables in SQL.

I used this result:

https://docs.sqlalchemy.org/en/20/core/metadata.html

bbelderbos commented 1 year ago

SQLModel.metadata.drop_all(engine) - I don't think we need that, why do you want to drop the tables?

CodeConnoisseur74 commented 1 year ago

@bbelderbos It was the only way I was able to make my changes work. I'll drop it thought , as I assume that future data would never be saved?

bbelderbos commented 1 year ago

@bbelderbos It was the only way I was able to make my changes work. I'll drop it thought , as I assume that future data would never be saved?

What do you mean?

CodeConnoisseur74 commented 1 year ago

@bbelderbos So I just pushed this branch again with the removal of drop_all. I don't see it here to create another pull request. I think I'm a little confused about that.

CodeConnoisseur74 commented 1 year ago

@bbelderbos Ok I see now that there are two commits for this branch.