CodeConstruct / mctp

MCTP userspace tools
GNU General Public License v2.0
32 stars 19 forks source link

mctpd: Set initial route MTU to interface minimum #51

Closed mkj closed 1 month ago

mkj commented 2 months ago

This allows better compatibility with devices that have a low initial allowed packet size and require application negotiation to increase that packet size.

Previously the MTU was left at 0, so matching the currently set MTU of the device.

jk-ozlabs commented 2 months ago

Couple of minor things:

Previously the MTU was left at 0, so matching the currently set MTU of the device.

Might be good to clarify this with "link" (or "interface") rather than "device". In the previous paragraph, "device" refers to the remote endpoint.

Could you add a signed-off-by too?

This probably warrants changelog entry as well, as it may trigger application changes.