CodeCrafter47 / BungeeTabListPlus

GNU General Public License v3.0
145 stars 70 forks source link

Vault money and group aren't showing in Sponge #167

Open Eufranio opened 7 years ago

Eufranio commented 7 years ago

As sponge doesn't have a proper Vault (all is handled my the API), it wont show my money and group in the vault variables, I think you could fix this.

CodeCrafter47 commented 7 years ago

Actually I think it does show most of the vault placeholders if you use version 2.6.4.

However when using the latest dev-build you need to use these placeholders: sponge_balance, sponge_balance2, sponge_primary_group, sponge_prefix, sponge_suffix, sponge_currency, sponge_currency_plural.

I made separate placeholders for sponge because I thought it might not be intuitive if you have to use placeholders like vault_balance in connection with sponge servers.

Eufranio commented 7 years ago

If I use it, what will be displayed in the Spigot servers? (since I use a global tablist)

CodeCrafter47 commented 7 years ago

No for the spigot server you have to use the usual vault placeholders.

Eufranio commented 7 years ago

I use a global tablist then... what should I use?

CodeCrafter47 commented 7 years ago

both

Eufranio commented 7 years ago

How? lol

CodeCrafter47 commented 7 years ago

If not connected to a sponge server ${viewer sponge_balance} will be replaced with an empty string. So you can just use both placeholders (${viewer sponge_balance} and ${viewer vault_balance}) in one slot of the tab list.

Example how to do it:

- {text: "&cBalance: &6${viewer vault_balance 1.2}${viewer sponge_balance 1.2}", icon: "default/balance.png", ping: 0}

Please not that you're using a dev-build and this behavior might change. Since you brought this up I think it might be easier to have a single placeholder that works on either platform. Not quite sure how to do that, from my point of view it is counter-intuitive if the vault_balance placeholder displays the balance on a sponge server (which does not have vault), which is why I changed it in the first place.

Eufranio commented 7 years ago

I think the variable should be the same, not different as it is now, because Sponge doesn't and never will have an Vault plugin, since the SpongeAPI is one (has all the features, permissions, economy, prefix/suffix, etc). So, makes sense use the vault variable because sponge IS the vault.

Zendrex commented 7 years ago

@CodeCrafter47 Seems sponge_primary_group isnt working. Using 2.6.5 (both the bridge and bungee)

My snippet:

footer:
  - |-
    &r
    &lPlayer Information&r
    &7${viewer name} (${viewer client_version}) &8- &7${viewer sponge_primary_group}
    &8${viewer uuid}
    &r
CodeCrafter47 commented 7 years ago

I'll look into fixing that.

CodeCrafter47 commented 7 years ago

The latest dev-build removes the sponge specific placeholders, the vault placeholder can now be used to display the permission and economy data on a sponge server, just as it works in version 2.6.4 of the plugin. The ${viewer vault_primary_group} placeholder will display the group information on sponge.

Rikudouu commented 7 years ago

I'm actually having this exact same issue with version 2.8.0 of the plugin. Using spongeforge-1.10.2-2281-5.2.0-BETA-2464, and balance doesn't show up. I have both the bridge and the bungeecord version installed, and there are no errors in either console.

CodeCrafter47 commented 7 years ago

What does /btlp status say?

Rikudouu commented 7 years ago

09:43:19 [INFO] You are running BungeeTabListPlus version 2.8.0 09:43:19 [INFO] Looking for an update... 09:43:19 [INFO] You are already running the latest version. 09:43:19 [INFO] Status of the bridge plugin is not known on: Modded, Vanilla, Lo bby 09:43:19 [INFO] Thanks for using BungeeTabListPlus.

Interesting how it says it doesn't know the status of the bridge plugin for "Modded", because that's my Sponge server (the rest are offline). I have the plugin installed in the correct place.

CodeCrafter47 commented 7 years ago

It can only ever know the status if the server is running and a player is connected to it. Also you need to run the same version of BTLP on BungeeCord and Sponge.

Rikudouu commented 7 years ago

I am running the same version on both. Here is the output after I connected to the server:

09:51:56 [INFO] You are running BungeeTabListPlus version 2.8.0 09:51:56 [INFO] Looking for an update... 09:51:57 [INFO] You are already running the latest version. 09:51:57 [INFO] Servers without the bridge plugin: Modded 09:51:57 [INFO] Status of the bridge plugin is not known on: Vanilla, Lobby 09:51:57 [INFO] Thanks for using BungeeTabListPlus.

CodeCrafter47 commented 7 years ago

Here it can't detect the bridge plugin. Please check the log of the sponge server whether the bridge plugin is loaded and running without errors.

Rikudouu commented 7 years ago

While I won't paste the entire Sponge log, here are all of the instances where the log mentions "BungeeTab"

[09:50:54] [Server thread/DEBUG] [FML/]: Found a candidate zip or jar file BungeeTabListPlus_SpongeBridge-2.8.0.jar
[09:50:55] [Server thread/DEBUG] [FML/]: Examining file BungeeTabListPlus_SpongeBridge-2.8.0.jar for potential mods
[09:50:55] [Server thread/TRACE] [FML/]: Located mcmod.info file in file BungeeTabListPlus_SpongeBridge-2.8.0.jar
[09:50:55] [Server thread/DEBUG] [FML/]: Identified a mod of type Lorg/spongepowered/api/plugin/Plugin; (codecrafter47.bungeetablistplus.spongebridge.SpongePlugin) - loading
[09:50:57] [Server thread/DEBUG] [FML/]:    bungeetablistplus(BungeeTabListPlus-SpongeBridge:2.8.0): BungeeTabListPlus_SpongeBridge-2.8.0.jar ()
[09:50:57] [Server thread/INFO] [FML/FML]: Attempting connection with missing mods [mcp, FML, Forge, spongeapi, sponge, nucleus-mixin, mercurius_updater, bungeetablistplus, flexiblelogin, foxcore, foxguard, huskyui, luckperms, market, mmcrestrict, nucleus, payday, placeholderapi, pjc, pjw, signeditor, skinsrestorer, tim, totaleconomy, ultimatechat, worldedit] at CLIENT
[09:50:57] [Server thread/INFO] [FML/FML]: Attempting connection with missing mods [mcp, FML, Forge, spongeapi, sponge, nucleus-mixin, mercurius_updater, bungeetablistplus, flexiblelogin, foxcore, foxguard, huskyui, luckperms, market, mmcrestrict, nucleus, payday, placeholderapi, pjc, pjw, signeditor, skinsrestorer, tim, totaleconomy, ultimatechat, worldedit] at SERVER
[09:50:58] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sending event FMLConstructionEvent to mod bungeetablistplus
[09:50:58] [Server thread/DEBUG] [FML/bungeetablistplus]: Attempting to inject @SidedProxy classes into bungeetablistplus
[09:50:58] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sent event FMLConstructionEvent to mod bungeetablistplus
[09:50:58] [Server thread/DEBUG] [FML/]: Bar Step: Construction - BungeeTabListPlus-SpongeBridge took 0.039s
[09:50:58] [Server thread/DEBUG] [FML/]:        bungeetablistplus   (BungeeTabListPlus-SpongeBridge 2.8.0)  BungeeTabListPlus_SpongeBridge-2.8.0.jar
[09:51:02] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sending event FMLPreInitializationEvent to mod bungeetablistplus
[09:51:02] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sent event FMLPreInitializationEvent to mod bungeetablistplus
[09:51:02] [Server thread/DEBUG] [FML/]: Bar Step: PreInitialization - BungeeTabListPlus-SpongeBridge took 0.000s
[09:51:03] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sending event FMLInitializationEvent to mod bungeetablistplus
[09:51:03] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sent event FMLInitializationEvent to mod bungeetablistplus
[09:51:03] [Server thread/DEBUG] [FML/]: Bar Step: Initialization - BungeeTabListPlus-SpongeBridge took 0.000s
[09:51:03] [Server thread/TRACE] [FML/]: Attempting to deliver 0 IMC messages to mod bungeetablistplus
[09:51:03] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sending event IMCEvent to mod bungeetablistplus
[09:51:03] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sent event IMCEvent to mod bungeetablistplus
[09:51:03] [Server thread/DEBUG] [FML/]: Bar Step: InterModComms$IMC - BungeeTabListPlus-SpongeBridge took 0.000s
[09:51:04] [Server thread/DEBUG] [FML/]: Bar Step: PostInitialization - mercurius_updater took 0.005s
[09:51:04] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sending event FMLPostInitializationEvent to mod bungeetablistplus
[09:51:04] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sent event FMLPostInitializationEvent to mod bungeetablistplus
[09:51:04] [Server thread/DEBUG] [FML/]: Bar Step: PostInitialization - BungeeTabListPlus-SpongeBridge took 0.000s
[09:51:05] [Server thread/DEBUG] [FML/]: Bar Step: LoadComplete - mercurius_updater took 0.000s
[09:51:05] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sending event FMLLoadCompleteEvent to mod bungeetablistplus
[09:51:05] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sent event FMLLoadCompleteEvent to mod bungeetablistplus
[09:51:05] [Server thread/DEBUG] [FML/]: Bar Step: LoadComplete - BungeeTabListPlus-SpongeBridge took 0.000s
[09:51:05] [Server thread/DEBUG] [FML/]: Bar Step: ServerAboutToStart - mercurius_updater took 0.000s
[09:51:05] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sending event FMLServerAboutToStartEvent to mod bungeetablistplus
[09:51:05] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sent event FMLServerAboutToStartEvent to mod bungeetablistplus
[09:51:05] [Server thread/DEBUG] [FML/]: Bar Step: ServerAboutToStart - BungeeTabListPlus-SpongeBridge took 0.000s
[09:51:05] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sending event FMLModIdMappingEvent to mod bungeetablistplus
[09:51:05] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sent event FMLModIdMappingEvent to mod bungeetablistplus
[09:51:05] [Server thread/DEBUG] [FML/]: Bar Step: ModIdMapping - BungeeTabListPlus-SpongeBridge took 0.000s
09:51:08] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sending event FMLServerStartingEvent to mod bungeetablistplus
[09:51:08] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sent event FMLServerStartingEvent to mod bungeetablistplus
[09:51:08] [Server thread/DEBUG] [FML/]: Bar Step: ServerStarting - BungeeTabListPlus-SpongeBridge took 0.000s
[09:51:08] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sending event FMLServerStartedEvent to mod bungeetablistplus
[09:51:08] [Server thread/TRACE] [bungeetablistplus/bungeetablistplus]: Sent event FMLServerStartedEvent to mod bungeetablistplus
[09:51:08] [Server thread/DEBUG] [FML/]: Bar Step: ServerStarted - BungeeTabListPlus-SpongeBridge took 0.000s

I wasn't able to find any errors in the log.

CodeCrafter47 commented 7 years ago

I did some more testing and it appears that it works fine using SpongeVanilla, but doesn't work when using SpongeForge.

Rikudouu commented 7 years ago

I was trying some things out, and I think I may have stumbled upon the solution, but I haven't tested it yet. The balance started working all of a sudden, and I suspect it might have something to do with the "SpongePls" plugin for bungeecord, which fixes some things with bungeecord and forge support.

CodeCrafter47 commented 7 years ago

I did some testing today and it seems that the SpongeBridge on a forge server only works when using Waterfall or SpongePls and a forge client (doesn't work using a vanilla client). This leads me to think that this isn't an issue of my plugin.

MarkL4YG commented 7 years ago

On top of that the SpongeBridges current build is build against SpongeAPI-7 (bleeding) which makes it unusable for stable-branch servers and servers having to stick to 1.10.2 due to modifications not keeping up - as normal.