[1.12] LEAK: ByteBuf.release() was not called before it's garbage-collected

CodeCrafter47 / BungeeTabListPlus

GNU General Public License v3.0

148 stars 70 forks source link

[1.12] LEAK: ByteBuf.release() was not called before it's garbage-collected #255

Open FiveEYZ opened 7 years ago

FiveEYZ commented 7 years ago

Was working fine on 1.11.2, but after i updated everything to 1.12 I started to see this memory leak message in console.

Its happening on a spongeForge server where im using:

Versions:

BungeeTabListPlus_SpongeBridge-2.8.1-SNAPSHOT
spongeforge-1.12-2397-7.0.0-BETA-2486

https://gist.github.com/FiveEYZ/e2a59d1f037b25d5841701406746d58e

Here is the BungeeCord im using:

Versions:

https://github.com/HexagonMC/BungeeCord/releases/tag/v158
BungeeTabListPlus-2.8.1-SNAPSHOT

CodeCrafter47 commented 7 years ago

In my opinion this is a Sponge issue: Plugins have no direct access to the ByteBuf object and have no way to release the buffer, nor does the API documentation state this would be necessary, so I assume the intention is that Sponge releases the buffer after use.