CodeCrafter47 / BungeeTabListPlus

GNU General Public License v3.0
142 stars 70 forks source link

Velocity Support? #405

Open OverCrave opened 5 years ago

OverCrave commented 5 years ago

Would it be possible to add support for Velocity at some point?

CodeCrafter47 commented 5 years ago

While technically possible, it's unlikely to happen. The reasons behind this are

  1. Velocity's API is much more limited than BungeeCord's API. To enable tab list modifications one would need to use Reflection and similar mechanisms to hack into Velocity's code. Doing this without breaking a lot of other stuff is a demanding task.

  2. I don't see myself adding support for velocity in near future. My work on support for other platforms is currently targeted towards on a standalone Spigot version of the plugin.

Stixil commented 3 years ago

It's been a couple of years since the response on this, but I wanted to check again on whether or not this is a possibility? Absolutely love the plugin and would have to have to leave it behind switch to Velocity for our proxy.

I realize it's a bit ironic being titled "Bungee"TabListPlus and supporting Velocity, but it would certainly be an exciting feature, maybe as a premium version?

Thanks!

Andre601 commented 3 years ago

I realize it's a bit ironic being titled "Bungee"TabListPlus and supporting Velocity, but it would certainly be an exciting feature, maybe as a premium version?

It's even more funny when you also realize that he made a Spigot version and called if "AdvancedTabOverlay" and not like "SpigotTabListPlus" simply because (iirc) he didn't want to suggest this being an Spigot-exclusive plugin or something. But having Bungee in this plugin is perfectly fine /s

@CodeCrafter47 You should reconsider Velocity support here. Since your post has the API of Velocity changed in many ways including new API features. Additionally is there a v3 of the proxy planned and in development, so perhaps you could give your input for possible additions to the API while it is being redone.

Stixil commented 3 years ago

Yes, I have to agree with Andre here about how Velocity is looking. So much has changed and improved over the last two years, it's a very exciting new platform that seems to be getting far more intuitive with each revision.

andreasdc commented 3 years ago

@CodeCrafter47 I would love to see that too :)

Stixil commented 3 years ago

Yes please, and checking again, thanks!

andythetech commented 2 years ago

Velocity supports tab list modification: https://github.com/VelocityPowered/Velocity/pull/105

Stixil commented 2 years ago

Velocity supports tab list modification: VelocityPowered/Velocity#105

That would make this pretty simple I think?

andreasdc commented 2 years ago

Does even Velocity has better performance than bungee or it doesn't have any sense?

andythetech commented 2 years ago

Does even Velocity has better performance than bungee or it doesn't have any sense?

Yes, that's exactly why it exists.

andreasdc commented 2 years ago

Does even Velocity has better performance than bungee or it doesn't have any sense?

Yes, that's exactly why it exists.

You have any comparison? Graphs?

andythetech commented 2 years ago

Does even Velocity has better performance than bungee or it doesn't have any sense?

Yes, that's exactly why it exists.

You have any comparison? Graphs?

You can do that research yourself. I'm just here to support this suggestion.

andreasdc commented 2 years ago

Does even Velocity has better performance than bungee or it doesn't have any sense?

Yes, that's exactly why it exists.

You have any comparison? Graphs?

You can do that research yourself. I'm just here to support this suggestion.

I did and there is no proper evidence

andythetech commented 2 years ago

Does even Velocity has better performance than bungee or it doesn't have any sense?

Yes, that's exactly why it exists.

You have any comparison? Graphs?

You can do that research yourself. I'm just here to support this suggestion.

I did and there is no proper evidence

I don't really understand why you're arguing with me, I am just here as someone that supports Velocity. You don't have to argue with me because of that. My network uses Velocity and as such we'd like to see a port of this plugin.

Andre601 commented 2 years ago

Can you guys just stop? Some of us don't want notifications of you guys arguying about such pointless things.

And for the record: Velocity is made by a contributor of Waterfall with the goal of having a better proxy with more performance and better coding standards.

Please do proper reseach next time and move this to another place now: https://velocitypowered.com/wiki/users/comparisons-to-other-proxies/

mibby commented 2 years ago

+1 for velocity support. Would be great to see and is the only plugin holding me back from migrating to the newer proxy.

I noticed this fork which has early velocity work done, but not sure how ready it is. https://github.com/aurorasmiles/BungeeTabListPlus/commits/velocity

johnfriedrich commented 2 years ago

Since this issue was opened, Velocity improved a lot. Out network moves to Velocity aswell, as Bungee does not support modern Forge. As more and more servers are moving to modern Forge version, Velocity will get a way more popular as it was in the last 1-2 years. Would be really happy if this plugin gets a Velocity version aswell!

Andre601 commented 2 years ago

Since this issue was opened, Velocity improved a lot. Out network moves to Velocity aswell, as Bungee does not support modern Forge. As more and more servers are moving to modern Forge version, Velocity will get a way more popular as it was in the last 1-2 years. Would be really happy if this plugin gets a Velocity version aswell!

There are a few core problems and limitations that make Velocity support harder.

For once is Velocity not relying on a basic Class extending Plugin class system like BungeeCord does. It uses injection which makes it more difficult to obtain useful information such as plugin name/id for things such as placeholders.

A workaround for this would be to make the Placeholder stuff use a String as id or a sort of unified GenericPlugin class that would do the job, but that's just some speculation, as there could be other issues and problems here.

I myself tried to add Velocity support (See #655) but the above fact and the fact that I would need to also alter other repositories AND deal with SymLink stuff made me decide to not continue this...

andreasdc commented 2 years ago

Since this issue was opened, Velocity improved a lot. Out network moves to Velocity aswell, as Bungee does not support modern Forge. As more and more servers are moving to modern Forge version, Velocity will get a way more popular as it was in the last 1-2 years. Would be really happy if this plugin gets a Velocity version aswell!

There are a few core problems and limitations that make Velocity support harder.

For once is Velocity not relying on a basic Class extending Plugin class system like BungeeCord does. It uses injection which makes it more difficult to obtain useful information such as plugin name/id for things such as placeholders.

A workaround for this would be to make the Placeholder stuff use a String as id or a sort of unified GenericPlugin class that would do the job, but that's just some speculation, as there could be other issues and problems here.

I myself tried to add Velocity support (See #655) but the above fact and the fact that I would need to also alter other repositories AND deal with SymLink stuff made me decide to not continue this...

Did you try asking Velocity to add easier implementation of your features? They added some things as I remember, for me personally BTLP is the only thing (other than recoding couple of my plugins) that stops me from migrating to Velocity.

AlexanderMoebius commented 3 months ago

Would be interesting if this is planed now that waterfall is end of life. Else I would have to look for alternatives.

Andre601 commented 3 months ago

Would be interesting if this is planed now that waterfall is end of life. Else I would have to look for alternatives.

The main issue is to still figure out what can/should be done on Velocity to achieve a similar set of functionality compared to BungeeCord. Any help in getting this to work would alsways be apreciated.

Andre601 commented 3 months ago

Also, to further add to this, Paper's announcement of "end of life" for waterfall is kind of a lie. The reason I say this is, that they mention to still do commits to Waterfall in the future. The only difference would be that those would be fewer and of less importance... Which already was the case pretty much for the past few weeks/months on the project. Also, BTLP is mainly made for BungeeCord, which won't see any EoL soon, so there is no hurry here on adding Velocity support given BungeeCord remains.

broken1arrow commented 3 weeks ago

Also, to further add to this, Paper's announcement of "end of life" for waterfall is kind of a lie. The reason I say this is, that they mention to still do commits to Waterfall in the future. The only difference would be that those would be fewer and of less importance... Which already was the case pretty much for the past few weeks/months on the project. Also, BTLP is mainly made for BungeeCord, which won't see any EoL soon, so there is no hurry here on adding Velocity support given BungeeCord remains.

I think they not yet is ready to cut the ties to spigot, as it does support more descent plugins than what velocity have. The owner decided to move to velocity due to waterfall is "end of life" and does not have 1.20.1 support yet as velocity have.

They are really slow to update waterfall compere to the past, so I think one day we need to move.

Andre601 commented 3 weeks ago

Always keep one aspect in mind, which is that BungeeCord - the Upstream of Waterfall - remains maintained. Yes, Waterfall is better in performance (Tho last time I checked I have not noticed any real differences in the cases I used BungeeCord and Waterfall in), but its end does not mean that all of BungeeCord will end too.

The owner decided to move to velocity due to waterfall is "end of life" and does not have 1.20.1 support yet as velocity have.

Nobody in their right mind supports 1.20.1. They either support 1.20.4 or 1.20.6 as the latest 1.20 versions, or update to 1.21, which Waterfall also has versions for (Probs mostly automated builds, but still) grafik

Andre601 commented 3 weeks ago

Generally speaking, Velocity support should result in a completely different plugin here... Squeezing it into the already existing codebase of BTLP would be a nightmare to deal with in many ways, so making a clean start with a dedicated, separate plugin would be a much better choice here, at the cost of possibly more work (Also, the name BungeeTabListPlus simply doesn't go well on Velocity, let's be honest).

broken1arrow commented 2 weeks ago

Always keep one aspect in mind, which is that BungeeCord - the Upstream of Waterfall - remains maintained. Yes, Waterfall is better in performance (Tho last time I checked I have not noticed any real differences in the cases I used BungeeCord and Waterfall in), but its end does not mean that all of BungeeCord will end too.

The owner decided to move to velocity due to waterfall is "end of life" and does not have 1.20.1 support yet as velocity have.

Nobody in their right mind supports 1.20.1. They either support 1.20.4 or 1.20.6 as the latest 1.20 versions, or update to 1.21, which Waterfall also has versions for (Probs mostly automated builds, but still) ![grafik](https://private-user-

Was 1.21 I meant. So a typo. They finally realized waterfall update, it did not exist yesterday.

And I agree, it is preferably better make new plugin with same or better functionality for Velocity. The current tab plugins for Velocity is not good at all.