CodeCrafter47 / BungeeTabListPlus

GNU General Public License v3.0
145 stars 70 forks source link

Option experimentalTabCompleteFixForTabSize80 doesn't work #719

Open andreasdc opened 1 year ago

andreasdc commented 1 year ago

The experimentalTabCompleteFixForTabSize80 option doesn't work I guess? image

Andre601 commented 1 year ago

Do you actually use a fixed size tab list with size 80?

andreasdc commented 1 year ago

type: FIXED_SIZE size: 80

CodeCrafter47 commented 1 year ago

The option only works for clients on version 1.19.2 or older.

andreasdc commented 1 year ago

Is workaround possible?

andreasdc commented 1 year ago

Maybe something like custom, secret or near empty names?

andreasdc commented 1 year ago

bump

Andre601 commented 1 year ago

Bumping won't make it be solved any faster. Be patient

CodeCrafter47 commented 1 year ago

The experimentalTabCompleteFixForTabSize80 option no longer works for the latest Minecraft versions. This is due to changes on the client and there is nothing I can do to fix it.

The experimentalTabCompleteSmileys option should still work, though.

andreasdc commented 1 year ago

What did change exactly?

Andre601 commented 1 year ago

This is me guessing but since 1.19.3 are players no longer required to be in the tab list to have their skin displayed in the server, so this is probably the cause, as the Client no longer needs to get the Player tab info for seeing the other players on the server. So maybe some relevant code that made the experimental option work has been removed or changed.

andreasdc commented 1 year ago

Isn't it better to keep the fix?

CodeCrafter47 commented 1 year ago

The previous fix relied on the minecraft client using a specific datastructure to store the tab list entries. We used the empty string as name (which doesn't show up in tab completion) and tweaked the entries, such that the hash function would ensure the correct order. I don't remember the details, but I looked at it when the 1.19.3 update has been published, and a similar fix is no longer possible.

andreasdc commented 1 year ago

I don't understand this, can you take a look into it by any chance?

Andre601 commented 1 year ago

He just told you that he can't fix it...

andreasdc commented 1 year ago

no