Reordering of Tags makes snapshot impossible on CreateGIFVC

CodeCraftersIO / GifWallet

MIT License

0 stars 5 forks source link

Reordering of Tags makes snapshot impossible on CreateGIFVC #16

Open daiku60 opened 5 years ago

daiku60 commented 5 years ago

In 635e70f, any time a snapshot test is run, the values of the tags are ordred differently. Propose a solution for that, so that the tags are always ordrered the same way

deceroainfinito commented 5 years ago

I would use this

self.tagView.addTags(Array(vm.tags).sorted(by: <))

in GIFDetailsViewController's configureFor method.

piercifani commented 5 years ago

I like it, go ahead and propose a PR!

deceroainfinito commented 5 years ago

Done