search

CodeCumbria / codecumbria.github.io

The Code Cumbria website
https://codecumbria.org
MIT License
1 stars 2 forks source link

Add gemfile and update devel help #13

Closed lantins closed 10 years ago

lantins commented 10 years ago

I needed a little more help to get started editing the site, I think these changes would make it quicker for someone else in the future.

adonaldson commented 10 years ago

Looks good, ta.

Can you commit the Gemfile.lock too?

Not really a comment about your commits, just thinking out loud: I wonder if we need to update the gitignores etc to remove assets. The output of anything 'built' shouldn't really be in the repo. Unless it's a github-pages requirement!

lantins commented 10 years ago

RE: assets. AFAIK these are compiled by Grunt and will not be compiled by GitHub, so they will need to be included in the repo.

RE: Gemfile.lock While it's standard to include Gemfile.lock for "applications", as far as I know, GitHub will ignore the Gemfile.lock when its building pages, that's why I thought it would be better to leave it out.

Thoughts?

adonaldson commented 10 years ago

Two things come to mind:

I cloned the repo, ran through the instructions without changing anything and I had a new file (Gemfile.lock) that needed committing. It'll just be a matter of time before someone commits theirs by accident. So we can either gitignore it, or commit it now.

If we commit it, then we're locking OUR version of github-pages to X. Whenever we run the code locally, we'll all be running the same version of the gem. If Github chooses to ignore Gemfile.lock that's fine (it's their server!) but as long as we all run the same version we shouldn't run into any 'hey it works for me' problems.

lantins commented 10 years ago

@adonaldson I like your thinking, valid point!

schwuk commented 10 years ago

Assets have to be committed - GitHub will not build them for us. However they should always be built using grunt production before committing.

adonaldson commented 10 years ago

Ok, thanks @schwuk, thought that might be the case, but it's still gross to have to do that.

Do we have to recompile anything before we can merge this PR?