CodeDistillery / angular-no-captcha

Angular.JS wrapper for Google's No CAPTCHA reCAPTCHA
http://codedistillery.github.io/angular-no-captcha/
MIT License
42 stars 21 forks source link

Documentation Typo #37

Closed AThilenius closed 7 years ago

AThilenius commented 7 years ago

There is a minor typo in your read me:

angular.module('myApp')
  .config(['noCAPTCHAProvider', function (noCaptchaProvider) {
    noCaptchaProvider.setSiteKey('<your site key>');
    noCaptchaProvider.setTheme('dark');
  }
]);

Should be

angular.module('myApp')
  .config(['noCAPTCHAProvider', function (noCaptchaProvider) {
    noCAPTCHAProvider.setSiteKey('<your site key>');
    noCAPTCHAProvider.setTheme('dark');
  }
]);
AThilenius commented 7 years ago

Sorry, I take that back lol.

AThilenius commented 7 years ago

However, for those of us that use Closure the code collapses to:

/** @ngInject */
function appConfigure(noCAPTCHAProvider) {
  noCAPTCHAProvider.setSiteKey('<key>');
};

So you may want to change your docs to:

angular.module('myApp')
  .config(['noCAPTCHAProvider', function (noCAPTCHAProvider) {
    noCAPTCHAProvider.setSiteKey('<your site key>');
    noCAPTCHAProvider.setTheme('dark');
  }
]);