CodeDredd / pinia-orm

The Pinia plugin to enable Object-Relational Mapping access to the Pinia Store.
https://pinia-orm.codedredd.de/
MIT License
444 stars 38 forks source link

fix(pinia-orm): Get mutators were wrong for updated models #1824

Closed CodeDredd closed 4 months ago

CodeDredd commented 4 months ago

🔗 Linked issue

related #1818

❓ Type of change

📚 Description

The get mutators & casts were still wrong for updated data. Now there is a design change for model properties who have casts or mutators. The performance will be a bit slower in some edge cases because shadow props are now introduced.

📝 Checklist

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.67%. Comparing base (76eb4a5) to head (99df5da).

Files Patch % Lines
packages/pinia-orm/src/model/Model.ts 96.77% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1824 +/- ## ======================================= Coverage 99.67% 99.67% ======================================= Files 87 87 Lines 5900 5923 +23 Branches 500 505 +5 ======================================= + Hits 5881 5904 +23 - Misses 16 17 +1 + Partials 3 2 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.