search

CodeDredd / pinia-orm

The Pinia plugin to enable Object-Relational Mapping access to the Pinia Store.
https://pinia-orm.codedredd.de/
MIT License
444 stars 38 forks source link

Inconsistency in has_many_save_uid test ? #1875

Open oaubert opened 3 months ago

oaubert commented 3 months ago

In https://github.com/CodeDredd/pinia-orm/blob/5813664d03e46a86a9ffb0e13dc4d51c8e211fb4/packages/pinia-orm/tests/feature/relations/has_many_save_uid.spec.ts#L17 the userId key is declared as a number, while the declaration in the User class states that it is a uid (string): @Uid() id!: string. It looks like an inconsistency.

CodeDredd commented 3 months ago

You are right i defined the wrong type for userId. Not all tests are perfectly written 😉