CodeDrivenMitch / axon-open-admin

Axon Open Admin
MIT License
22 stars 6 forks source link

Interceptor should not block axon query #57

Closed janvonneree closed 12 months ago

janvonneree commented 1 year ago

Maybe a really rare case but the axon open admin should not block axon functionalities.

`Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is java.util.ConcurrentModificationException] with root cause

java.util.ConcurrentModificationException: null at java.base/java.util.HashMap.computeIfAbsent(HashMap.java:1221) at com.insidion.axon.openadmin.insights.InsightRegistrationService.reportOriginMessage(InsightRegistrationService.kt:16) at com.insidion.axon.openadmin.insights.InsightDispatchInterceptor.originDispatchInterceptor$lambda-2(InsightDispatchInterceptor.kt:49) at org.axonframework.messaging.MessageDispatchInterceptor.handle(MessageDispatchInterceptor.java:43) at org.axonframework.axonserver.connector.DispatchInterceptors.intercept(DispatchInterceptors.java:45) at org.axonframework.axonserver.connector.query.AxonServerQueryBus.query(AxonServerQueryBus.java:258) at org.axonframework.queryhandling.DefaultQueryGateway.query(DefaultQueryGateway.java:84) at org.axonframework.queryhandling.QueryGateway.query(QueryGateway.java:91)`

Axon version: 4.6.8 Axon open admin version: 0.2.8

stefanzilske commented 1 year ago

@CodeDrivenMitch could you already have a look at this? It seems to happen from time to time and causes Axon queries to fail. Any hint would be appreciated if and when this could be fixed.

stefanzilske commented 1 year ago

@CodeDrivenMitch I made a small change, that should avoid concurrency issues in the InsightRegistrationService. It would be nice if you could merge and release it.

stefanzilske commented 1 year ago

@CodeDrivenMitch any news? Is this library dead?