CodeEditApp / CodeEdit

📝 CodeEdit App for macOS – Elevate your code editing experience. Open source, free forever.
https://codeedit.app
MIT License
21.16k stars 1.02k forks source link

LSP Document Content Sync #1887

Closed thecoolwinter closed 1 month ago

thecoolwinter commented 2 months ago

Description

[!NOTE] Requires https://github.com/CodeEditApp/CodeEdit/pull/1879 to be merged, based on that branch. This will look like it's a massive change until that is merged. Requires https://github.com/CodeEditApp/CodeEditSourceEditor/pull/265 to be merged as it provides the required APIs to make this work.

Changes:

Misc related changes:

Related Issues

Checklist

Screenshots

N/A

thecoolwinter commented 1 month ago

This is almost good to go. Only one thing needs to be changed.

Also while these changes are great, some of them seem unrelated to the main focus and might be better in a separate PR. I get that it's faster to put everything in one, but it makes reviewing and testing a bit harder (and I need to work on this too 😅). Thanks!

Yeah this one was particularly tangled with a few things since I did #1892 on this branch and had to split it off to make it its own PR. I left a few things here that's my bad.