search

CodeEditApp / CodeEditSourceEditor

A code editor view written in Swift powered by tree-sitter.
https://codeeditapp.github.io/CodeEditSourceEditor/documentation/codeeditsourceeditor
MIT License
510 stars 78 forks source link

Support a text wrapping preference in the textview #105

Closed ben-p-commits closed 1 year ago

ben-p-commits commented 1 year ago

Background

This addresses bug #84 , and fulfills some of the requirements of #66 (the rest of which will be implemented in CodeEdit in a nascent PR).

Technical Details

Two things to note:

  1. This will likely regress highlighting behavior- more detailed discussion available on this discord channel, but TLDR: @thecoolwinter has plans to obviate the need for the removed NSLayoutManager code when he migrates that work to TextKit 2.

  2. I went ahead and removed the invocation of STTextView's static scrollableTextView() helper function. It sets a number of properties which are immediately overwritten by our code in loadView(). It only obfuscates what's really happening here.

ben-p-commits commented 1 year ago

linting issues noted. will address.

lukepistrol commented 1 year ago

Let's just wait for the review of @thecoolwinter

ben-p-commits commented 1 year ago

@austincondiff , @lukepistrol - we should be all set to merge according to @thecoolwinter

I have the follow-on changes ready for CodeEdit.

lukepistrol commented 1 year ago

I'll tag a new version in a couple of hours!

lukepistrol commented 1 year ago

I just tagged the new release with 0.3.0