CodeEditApp / CodeEditSourceEditor

A code editor view written in Swift powered by tree-sitter.
https://codeeditapp.github.io/CodeEditSourceEditor/documentation/codeeditsourceeditor
MIT License
510 stars 78 forks source link

✨ Configuration to toggle line numbers visibility #115

Open vitalyster opened 1 year ago

vitalyster commented 1 year ago

Is your feature request related to a problem? Please describe.

Line numbers make UI bloated, we have line indicator in status bar

Describe the solution you'd like

Please hide line numbers by default

Describe alternatives you've considered

At least there should be an option to hide

Additional context

Screenshot 2023-01-13 at 03 52 24
lukepistrol commented 1 year ago

We probably won't hide the line numbers by default but having an option to turn them off seems like a good idea 👍

ben-p-commits commented 1 year ago

@lukepistrol - I'll take this one on.

austincondiff commented 1 year ago

Should we provide the ability to hide line numbers or hide the entire gutter which includes indications for code folding, code review, etc.? Maybe both (could be too much though)?

ben-p-commits commented 1 year ago

Anecdotal- but I believe people who ditch line numbers are probably good with eschewing folding, review- etc.

ben-p-commits commented 1 year ago
image

then again...

xcode goes all the way

image
ben-p-commits commented 1 year ago

@austincondiff, perhaps we add the options as separate enhancements when the respective functionality is implemented?

Hard to say whether the RulerView is going to be the container for those future features like a code ribbon, or if sibling views are needed for them.

austincondiff commented 1 year ago

I like that. If Xcode provides the ability to show/hide each thing individually, we should do the same.

ben-p-commits commented 1 year ago

@austincondiff, So- do we wait for those features to be implemented? 😆

ben-p-commits commented 1 year ago

https://github.com/CodeEditApp/CodeEditTextView/pull/124

@austincondiff , @lukepistrol, PR in the pocket.

austincondiff commented 1 year ago

@ben-p-commits No, just making a comment that we should hide just the line numbers here and the others as they get implemented. 😉