search

CodeEditApp / CodeEditSourceEditor

A code editor view written in Swift powered by tree-sitter.
https://codeeditapp.github.io/CodeEditSourceEditor/documentation/codeeditsourceeditor
MIT License
504 stars 74 forks source link

🐞 Line number briefly flashes in after changing appearance when clicking a line #176

Closed luah5 closed 8 months ago

luah5 commented 1 year ago

Description

In the opposite of the system theme, when clicking on a line the line number flashes for a split second for some reason this only happens when the theme is opposite of the system theme.

To Reproduce

  1. Set your theme to dark mode
  2. Open or create a file with 2 lines or more
  3. click on the line number's text and notice that it flashes

Expected Behavior

I would expect the line number to stay a solid color, not to change color like in Xcode and VS Code

Version Information

CodeEdit: [0.0.3-alpha.32] CodeEditTextView: [0.6.1] macOS: [13.2.1]

Screenshots

https://user-images.githubusercontent.com/128280019/232200794-6b46f4fa-96d9-4317-a1f9-3110e6c6b0c8.mov

austincondiff commented 1 year ago

I can reproduce this bug, however I don't think this is limited to dark mode. In my experience, it is the opposite appearance from which you loaded the app. For example if you opened CodeEdit in light mode, it happens in dark mode. If you've opened in dark mode, it happens in light mode.

luah5 commented 1 year ago

You're completely right! I'll edit the issue accordingly.

thecoolwinter commented 8 months ago

This was fixed in 2921e93d by @austincondiff.