[chore] Refactor STTextViewController to reduce duplication - Githubissues

CodeEditApp / CodeEditSourceEditor

A code editor view written in Swift powered by tree-sitter.

https://codeeditapp.github.io/CodeEditSourceEditor/documentation/codeeditsourceeditor

MIT License

504 stars 74 forks source link

[chore] Refactor STTextViewController to reduce duplication #185

Closed austincondiff closed 1 year ago

austincondiff commented 1 year ago

Description

Fixed a few UI bugs by reducing overlap between loadView and reloadUI and calling reloadUI from loadView. These include...

There were some areas where the theme background was not getting applied.
The currently selected line was not getting a background in the ruler view until changing a setting which called reloadUI.

Now loadView calls reloadUI which allows us to reduce code duplication

Related Issues

n/a

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] The issues this PR addresses are related to each other
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] My changes are all related to the related issue above
[x] I documented my code

Screenshots

n/a