CodeEditApp / CodeEditSourceEditor

A code editor view written in Swift powered by tree-sitter.
https://codeeditapp.github.io/CodeEditSourceEditor/documentation/codeeditsourceeditor
MIT License
504 stars 74 forks source link

🐞 Compile errors by SwiftLintPlugin #188

Closed LostInCompilation closed 1 month ago

LostInCompilation commented 1 year ago

Description

See CodeEditApp/CodeEdit#1267

When trying to compile the current sources with XCode 14.3 on macOS 13.3.1(a) I get the following compilation error:

.../CodeEditTextView/Tests/CodeEditTextViewTests/CodeEditTextViewTests.swift:4:1 Usage of // swiftlint:disable all is prohibited
.../CodeEditTextView/Tests/CodeEditTextViewTests/STTextViewControllerTests.swift:7:1 Usage of // swiftlint:disable all is prohibited

https://github.com/CodeEditApp/CodeEditTextView/blob/521dd433df903c405e1d7edc4d442ba7933f893c/Tests/CodeEditTextViewTests/CodeEditTextViewTests.swift#L4 https://github.com/CodeEditApp/CodeEditTextView/blob/521dd433df903c405e1d7edc4d442ba7933f893c/Tests/CodeEditTextViewTests/STTextViewControllerTests.swift#L7

The issues are raised by the packages CodeEditLanguages and CodeEditTextView. The cause is the latest update of SwiftLintPlugin from v0.2.2 to v0.2.3. This update updated SwiftLint from v0.50 to v0.51 which introduced stricter rules on blanket disable commands.

Disabling all SwiftLint checks is no longer supported. Only the necessary lint issues should be disabled.

To Reproduce

  1. Download a fresh clone of the CodeEditApp repo
  2. Build

Expected Behavior

No issues

Version Information

CodeEditTextView: 0.6.2 macOS: 13.3.1(a) Xcode: 14.3

Additional Context

No response

Screenshots

No response