search

CodeEditApp / CodeEditSourceEditor

A code editor view written in Swift powered by tree-sitter.
https://codeeditapp.github.io/CodeEditSourceEditor/documentation/codeeditsourceeditor
MIT License
504 stars 74 forks source link

šŸž Text scrolls underneath ruler #195

Closed wjk closed 8 months ago

wjk commented 1 year ago

Description

Apparently, CodeEditTextView does not fully take into account the size of the left-hand ruler when positioning its content. As a result, when I open a file in CodeEdit, the left-hand side of each line is cut off because it is being drawn underneath the ruler. I can scroll to the right to pull the content out from underneath the ruler, but this cuts off the part of the line at the right side of the screen. This is terribly annoying and makes line-wrap not work properly.

To Reproduce

  1. Open a file in CodeEdit
  2. Observe the cut off text and horizontal scrollbar

Expected Behavior

The text in the text view should appear to the right of the ruler, not under it. There should be no horizontal scrollbar.

Version Information

CodeEdit: 0.0.3-alpha (32) macOS: 13.4 (22F66) Xcode: 15.0 (15A5160n)

Additional Context

Previously reported as https://github.com/CodeEditApp/CodeEdit/issues/1306.

Screenshots

Screenshot 2023-06-09 at 9 01 14 PM Screenshot 2023-06-09 at 9 01 00 PM
luah5 commented 1 year ago

I'm pretty sure this was fixed in #177, are you running CodeEdit from Xcode or from the latest app release on github?

wjk commented 1 year ago

Latest release on GitHub. I tried to build from source first, but Xcode kept choking on the 70MB xcframework in CodeEditLanguages. It generally just quit downloading entirely, and I know of no good way to get it to resume without deleting the clones and starting over ā€” at which point Xcode usually chokes again. If you have any ideas as to how I could address this, Iā€™m all ears.

wjk commented 1 year ago

Strike that regarding the download errors. I have just got it to work.

thecoolwinter commented 8 months ago

This should be fixed with #211. The gutter has been reimplemented to be a floating view instead of a ruler view and the text view updated to account for that automatically.