search

CodeEditApp / CodeEditSourceEditor

A code editor view written in Swift powered by tree-sitter.
https://codeeditapp.github.io/CodeEditSourceEditor/documentation/codeeditsourceeditor
MIT License
517 stars 84 forks source link

🐞 Font doesn't apply consistently #55

Closed alicerunsonfedora closed 2 years ago

alicerunsonfedora commented 2 years ago

Description

When using a custom font, the editor appears to only apply that font to select areas when the file has syntax highlighting.

To Reproduce

  1. Open CodeEdit Settings > Text Editing.
  2. Change the font to anything other than the default.
  3. Open a file in CodeEdit.
  4. Notice the inconsistent font application.

Expected behavior

The same font should be used throughout the entire editor view, regardless of syntax highlighting.

Version information

CodeEdit: 1.0 Hash: (Commit) 095abfec2475ca053bb7783572e4ae9a38d514ea MacOS: 13.0 beta 4 (22A5311f) Xcode: 14.0 beta 4 (14A5284g)

Additional context

This is an example screenshot demoing the behavior. I've set my font to Fira Code Retina (size 13). Notice that, here, the identifier "Foundation" uses the correct font, as well as the line gutter, whereas everything else doesn't.

image
austincondiff commented 2 years ago

@lukepistrol is this a problem with CodeEditTextView? If so please transfer this issue.

lukepistrol commented 2 years ago

@thecoolwinter is this fixed with #59 ?

thecoolwinter commented 2 years ago

Yes, closed with #59