Closed James103 closed 1 year ago
I believe this is a case of modrinth caching my images for me, as my markdown already directly links to imgur as you suggested. You can confirm this yourself as the Readme.md here uses the same markdown as the one on the modrinth page.
I believe this is a case of modrinth caching my images for me
Can confirm this is the case. Checking the source code for the Modrinth backend, I find the following:
i.imgur.com
among others but not plain imgur.com
.https://wsrv.nl/?url=
to the URL, effectively forcing the image to be cached through a third-party service instead of being served directly.https://imgur.com/QTk8w33.gif
redirect to https://i.imgur.com/QTk8w33.gif
(the hostname changes from imgur.com
to i.imgur.com
.Therefore, I'd recommend updating links of the form https://imgur.com/QTk8w33.gif
on your readme file by changing imgur.com
to i.imgur.com
so Modrinth does not force the images to be cached through a third party wsrv.nl
.
In other words, for example, this is what you have on the README.md
:
https://github.com/CodeF53/Horse-Buff/blob/5156e1d977b7567a3e2cdf8710b2731ed72da4f7/README.md?plain=1#L19
During parsing, Modrinth changes the above line to:
![image](https://wsrv.nl/?url=https://imgur.com/JeJNEgO.gif)
I suggest changing it instead to:
![image](https://i.imgur.com/JeJNEgO.gif)
as that is what the original URL redirects to when followed in a browser.
Fixed for awhile now, but I finally pushed the changed readme to github
Some of the images in the mod's description (https://modrinth.com/mod/horsebuff) are not loading, for the following reason:
https://wsrv.nl/?url=https%3A%2F%2Fimgur.com%2FQTk8w33.gif
{"status":"error","code":404,"message":"The requested URL returned error: 403"}
Changing the URLs to fetch the image directly from imgur (
https://imgur.com/QTk8w33.gif
in this example) works properly.