search

CodeF53 / Horse-Buff

Makes Horses better by removing stupid things
Other
10 stars 7 forks source link

Is this supposed to work with mounts from Mythic Mounts? #44

Closed allanonmage closed 1 year ago

allanonmage commented 1 year ago

Based on the way the mounts in Mythic Mounts work with other horse-related mods, I expected them to work with your mod. So far, going through portals work, but the fade does not, so it's a mixed bag. Do you want to add support for mounts in general, or should I ask them to add support for your mod?

https://www.curseforge.com/minecraft/mc-mods/mythic-mounts

CodeF53 commented 1 year ago

I can't read their source code, so I have no idea why it wouldn't work.

My best guess is that they use some custom renderer.

CodeF53 commented 1 year ago

The the Mythic Mounts models are rendered/animated using GeckoLib, so the mounts use an extension of their renderer class GeoEntityRenderer.

So my mixin into the vanilla renderer doesn't apply to them.

If I ever feel like adding support, I got the developer to send me their source code for rendering.

discord server, message in discord with the source code (this mainly serves as a note to myself)

CodeF53 commented 1 year ago

Adding would require integration with GeckoLib, which I don't want to add as a dependency.