search

CodeF53 / Horse-Buff

Makes Horses better by removing stupid things
Other
10 stars 5 forks source link

Some changes don't sync well across client and server #48

Closed CodeF53 closed 2 months ago

CodeF53 commented 1 year ago

Unlike most settings, the Client just assumes it knows the correct Break Speed multipler, and doesn't ask the server about it.

This has the problem where:

  1. User with breakSpeed connected to unmodded server tries breaking a block -> Block comes back because they broke it too fast
  2. Unmodded user connected to server with breakSpeed tries breaking a block -> Block takes normal amount of time to mine, as the client assumes the breakspeed is still slow

Fix:

  1. Make ModifyConstant HorseBreakSpeed exclusive to Singleplayer
  2. Server gives players on HorseBack haste 25
CodeF53 commented 1 year ago

Also applies to stepHeight

  1. User with it enabled connected to unmodded server gets rubberbanded in a sickening manner (breaking what the server thinks should be possible
  2. unmodded user -> server with enabled -> user can't use extra step height (doesn't know there is any)

Fix:

  1. Make ModifyConstant StepHeight exclusive to Singleplayer 2, ??????????????????????????????????
CodeF53 commented 2 months ago

https://modrinth.com/mod/horsebuff/version/SlE8YgP0