CodeF53 / Horse-Buff

Makes Horses better by removing stupid things
Other
10 stars 5 forks source link

horse armor is not transparent when you're looking down #57

Closed peow closed 9 months ago

peow commented 9 months ago

If the horse has any armor, it is not transparent when the Player looks down

first pic: no armor second pic: putting armor third pic: with armor huge_2023-09-28_00 32 21 huge_2023-09-28_00 32 30 huge_2023-09-28_00 32 32

CodeF53 commented 9 months ago

Are you using any mods that effect the game rendering?

I remember this working perfectly in vanilla and sodium before.

peow commented 9 months ago

hmmm so this is a mod conflit, I'll try to find out which mod is causing the problem and let you know

peow commented 9 months ago

ok, I found the mod that was causing conflict, it was Shiny Horses, which basically adds enchantments to horse armor, and even though the armor I tested wasn't enchanted it still caused problems, i just disabled it

but, i discover another mod giving the same problem, the Universal Enchants mod, this mod also allows horse armor to be enchanted, so I imagine that's the problem with your mod: it doesn't recognize horse armor that can be enchanted

CodeF53 commented 9 months ago

More likely its them editing how horse armor is rendered to add an enchantment glint to it.

While I could implement a specific per-mod fix for this, that is hard to maintain and I am lazy.

CodeF53 commented 9 months ago

https://github.com/Fuzss/universalenchants/blob/4fc6169d1f4e642986109607449dc701ff6ae7a8/1.20/Common/src/main/java/fuzs/universalenchants/mixin/client/HorseArmorLayerMixin.java#L31C28-L31C28

This is what breaks transparency. Inorder to render things transparent it has to be on the correct render layer. I doubt there is even a render layer that supports the enchantment effect and transparency at the same time.

peow commented 9 months ago

i see, ok no problem

peow commented 7 months ago

how difficult would it be to put an option in the mod so that if the horse is wearing armor it doesn't try to become transparent? because it looks strange

2023-12-15_13 15 43

peow commented 4 months ago

hello?