CodeFlowOrg / forestTreesTagging

This project has the vision to assist the officials for Forest trees census and tagging each tree with proper location (latitude and longitude), tree type, and other arguments. and further had the plan to apply data analysis over-collected data.

20 stars 38 forks source link

Forgot Password Feature Added #78

Closed SamarpanCoder2002 closed 3 years ago

SamarpanCoder2002 commented 3 years ago

Description:

Forgot Password Feature Added in Log-In

Fixes #74

Type of change:

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.

Screenshots / Video:

I am also a GSSOC21 participant.... Please raise the corresponding label of this program...

Hope you review it and merge it soon @ghackg11

SamarpanCoder2002 commented 3 years ago

hello @ghackg11 .... Please review it and merge it ...Thanks

Sameerkash commented 3 years ago

@ghackg11 are we not using any separation of layers and state management like provider? the above approach would be hard to maintain and scale further down the line

ghackg11 commented 3 years ago

@ghackg11 are we not using any separation of layers and state management like provider? the above approach would be hard to maintain and scale further down the line

Yup, this is an issue, you can create new issues regarding that, and manage it for better Scalability of the code.

SamarpanCoder2002 commented 3 years ago

Hello @Sameerkash @ghackg11 I made changes in code according to all of you.... Please review it and merge it

Sameerkash commented 3 years ago

Also, I don't see any documentation in code

SamarpanCoder2002 commented 3 years ago

Also, I don't see any documentation in code

I made changes about 3 or 4 lines about forget password feature.... Variable and function name are user friendly to understand....Is it not enough??? @Sameerkash @ghackg11 .... Also, there is no other documentation before I start working on that....

SamarpanCoder2002 commented 3 years ago

As per requirement of @Sameerkash ...... I added Documentation for Forgot Password Feature Which I add here...

Hope this will be fine @ghackg11 @Sameerkash

SamarpanCoder2002 commented 3 years ago

As per requirement of @Sameerkash ...... I added Documentation for Forgot Password Feature Which I add here...

Hope this will be fine @ghackg11 @Sameerkash

Thanks for approve @Sameerkash ... Hope you review it and merge it soon @ghackg11 @vilsi12

SamarpanCoder2002 commented 3 years ago

Thanks for merge @ghackg11 .... Nice to work in that project

ghackg11 commented 3 years ago

Thanks for merge @ghackg11 .... Nice to work in that project

Nice to work with you too:)