search

CodeFoodPixels / node-promise-mysql

A wrapper for mysqljs/mysql that wraps function calls with Bluebird promises.
MIT License
338 stars 63 forks source link

Fix build on Node.js v0.10.x (#12) #13

Closed addaleax closed 8 years ago

addaleax commented 8 years ago

Adds Promise = require('bluebird'); to lib/helpers.js (#12). This fixes the test script on Node v0.10, i.e. before Promise became a builtin object in Node.js (and adds the consistency of exclusively using bluebird promises).

CodeFoodPixels commented 8 years ago

Thanks for this, I'll give it a check tomorrow and then if all is good, I'll merge!

addaleax commented 8 years ago

Great! It’s not like it’s urgent for me or anything, I just saw the bug report and was pretty sure about what was going on there :)

addaleax commented 8 years ago

And btw, would you be interested in using something like Travis CI? I’ve found it to be a great tool in testing for multiple Node.js versions, and if you’d be inclined to use it, I’d be more than happy to create a PR with the necessary setup.

CodeFoodPixels commented 8 years ago

That sounds like a great idea. I've never set Travis CI up before so it'd be awesome if you could do a PR and I can learn from it!

On Wed, 6 Jan 2016, 00:04 Anna Henningsen notifications@github.com wrote:

And btw, would you be interested in using something like Travis CI? I’ve found it to be a great tool in testing for multiple Node.js versions, and if you’d be inclined to use it, I’d be more than happy to create a PR with the necessary setup.

— Reply to this email directly or view it on GitHub https://github.com/lukeb-uk/node-promise-mysql/pull/13#issuecomment-169173944 .

CodeFoodPixels commented 8 years ago

Thanks for the fix @addaleax, I've merged it.