search

CodeFoodPixels / node-promise-mysql

A wrapper for mysqljs/mysql that wraps function calls with Bluebird promises.
MIT License
338 stars 63 forks source link

PoolCluster Support #146

Closed move-zig closed 3 years ago

move-zig commented 3 years ago

Adds support for pool clusters

move-zig commented 3 years ago

The test for poolCluster.on poolCluster.add is failing. The method has two signatures, one with one parameter and one with two. In typescript, you'd define both separately, but in plain javascript I think having just the second one would be fine? If keeping both is a good idea, the test has to be fixed.

CodeFoodPixels commented 3 years ago

I'll have a look at the test and see what you mean

CodeFoodPixels commented 3 years ago

Tests look to be passing now, I think you edited your message to say that it was poolCluster.add that was failing after I'd already seen your message, so I was a little lost as to what was wrong 🙈 Going to have a look through the rest, but I'm pretty happy

CodeFoodPixels commented 3 years ago

I'm happy to get this merged if you are @move-zig?

move-zig commented 3 years ago

Looks good. Thanks!