search

CodeFoodPixels / node-promise-mysql

A wrapper for mysqljs/mysql that wraps function calls with Bluebird promises.
MIT License
338 stars 64 forks source link

chore(typings): use `export class` #155

Closed casperiv0 closed 2 years ago

casperiv0 commented 3 years ago

This PR includes

use export class instead of export interface so the class can be extended in TypeScript files.

casperiv0 commented 3 years ago

Whoops, forgot to add the constructors. Adding these now added

move-zig commented 3 years ago

This change makes sense to me. If this was a native typescript project, the classes would have been exported.

This is a breaking change for typescript users. If we merge this, we'd need to move to 6.0.0.