replace bluebird promises by native promises

CodeFoodPixels / node-promise-mysql

A wrapper for mysqljs/mysql that wraps function calls with Bluebird promises.

MIT License

338 stars 64 forks source link

replace bluebird promises by native promises #159

Closed Kosta-Github closed 2 years ago

Kosta-Github commented 2 years ago

there is no need anymore to use bluebird promises instead of native promises
update tap to the latest version as well in order to address a vulnerability of the indirectly referenced lodash module

Kosta-Github commented 2 years ago

this PR would also supersede #158

CodeFoodPixels commented 2 years ago

I think by doing this, you'd lose a lot of the utility methods that Bluebird adds that the native promise spec doesn't have. If we were to do this, we'd need to do both a major version bump, and add something to the readme to say that people will need to use bluebird itself if they want those utility methods

Kosta-Github commented 2 years ago

My assumption is as well as my motivation for using this module to use mysql with promises, not with bluebird. IMHO, the current native promises are already feature reach. Or you can make the promise type a config option?

CodeFoodPixels commented 2 years ago

I understand your motivation for using this module, I was just stating that this would be a major version bump and that we'd need to advise users that this module has moved away from bluebird. I don't want to break people's code.