search

CodeFoodPixels / node-promise-mysql

A wrapper for mysqljs/mysql that wraps function calls with Bluebird promises.
MIT License
338 stars 63 forks source link

update to bluebird 3 #25

Closed linusnorton closed 7 years ago

linusnorton commented 8 years ago

Bluebird 3 comes with a handy mapSeries function, please update the version of bluebird used in this library.

CodeFoodPixels commented 8 years ago

I'll have a look.

On Thu, 22 Sep 2016, 11:52 Linus Norton, notifications@github.com wrote:

Bluebird 3 comes with a handy mapSeries function, please update the version of bluebird used in this library.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lukeb-uk/node-promise-mysql/issues/25, or mute the thread https://github.com/notifications/unsubscribe-auth/AEjy1Jh4tZROMDJvKu18XB2-y7S3TWU9ks5qsl30gaJpZM4KDwkF .

linusnorton commented 8 years ago

Thanks, the main breaking change seems to be this:

// 2.x
Promise.promisify(fn, ctx);
// 3.0
Promise.promisify(fn, {context: ctx});
G07cha commented 7 years ago

Hi, I've run tests with updated Bluebird and everything seems fine.

Is there any possible requirements or caveats? In node-promise-mysql Bluebird used only for creating new promises so breaking changes doesn't affect current functionality.

CodeFoodPixels commented 7 years ago

@G07cha That should be it. Feel free to send over a PR.