search

CodeFoodPixels / node-promise-mysql

A wrapper for mysqljs/mysql that wraps function calls with Bluebird promises.
MIT License
338 stars 64 forks source link

merge some code #30

Closed haixuxu closed 7 years ago

haixuxu commented 7 years ago

Merge duplicate definitions of code

CodeFoodPixels commented 7 years ago

I'm failing to see any benefit to this besides there being less code. It's less readable.

Also it seems to be breaking the tests.

CodeFoodPixels commented 7 years ago

To clarify, I closed this pull request because you kept updating the commits which sent me an email each time. Feel free to reopen it once you're happier with the code and you can justify the need for this.