search

CodeFoodPixels / node-promise-mysql

A wrapper for mysqljs/mysql that wraps function calls with Bluebird promises.
MIT License
338 stars 63 forks source link

Replaced bluebird dependency to native-or-bluebird #4

Closed byoigres closed 9 years ago

byoigres commented 9 years ago

Like native-or-bluebird says:

The goal of this library is to be able to eventually remove this line from your code and use native Promises, allowing you to to write future-compatible code with ease. You should install bluebird in your libraries for maximum compatibility

CodeFoodPixels commented 9 years ago

Looking at native-or-bluebird, it suggests to install bluebird in the project for maximum compatibility. Native-or-bluebird only contains it in the devDependencies, so it'd still be required in this project.

It also seems that it tries bluebird first so I'm not sure what the benefit of using native-or-bluebird would be?

CodeFoodPixels commented 9 years ago

Closing this because of lack of response, feel free to answer the question and I will re-open/merge if necessary.

byoigres commented 9 years ago

Well, you're right about trying to use bluebird first instead of native promises, if it was promises before Bluebird would make sense. Sorry to take too long to response.