CodeFoodPixels / robovac

Add a Eufy RoboVac easily to Home Assistant
Other
110 stars 26 forks source link

LR20 doesn't have consumables #8

Closed LarveyOfficial closed 10 months ago

LarveyOfficial commented 10 months ago

The LR20 is not an L series. It's an LR series and causes the console to flood with errors regarding consumables as it's not a feature (it doesn't have a mop). My original pull request went around this by ensuring a difference between LR and L, as well as adding an if statement with the state update function that checks the status of the consumables.

CodeFoodPixels commented 10 months ago

The Eufy website classes the LR and L as one series, which is why I combined them.

There are other vacuums with the LR prefix that do have a mop, so the LR distinction alone is not enough.

I'm going to separate out the consumables feature because I have a feeling that this may be something across other models too.

As an aside, I don't appreciate your tone at all. This isn't something I'm being paid to work on, and I can't be expected to know the ins and outs of every model. You don't need to be rude.

CodeFoodPixels commented 10 months ago

Fixed in 26cbc26