Implement Mapit - Githubissues

CodeForAfrica / HURUmap

HURUmap is an interactive web platform that allows citizens and journalists to explore, visualise, and download census data. This gives them the power to give context to stories that was otherwise hard to spot. Accessible at https://hurumap.org

https://hurumap.org

GNU General Public License v3.0

8 stars 7 forks source link

Implement Mapit #52

Closed KhadijaMahanga closed 5 years ago

KhadijaMahanga commented 5 years ago

Description

Mapit Implementation on HURUmap, default country KE

Fixes # (issue)

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Screenshots

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

KhadijaMahanga commented 5 years ago

@kilemensi the error min() args is an empty sequence is a data issue. You can remove it by running docker exec -it <hurumap container-id> ./contrib/loaddata.sh

KhadijaMahanga commented 5 years ago

@kilemensi this PR is ready for review

kilemensi commented 5 years ago

@kilemensi the error min() args is an empty sequence is a data issue. You can remove it by running docker exec -it <hurumap container-id> ./contrib/loaddata.sh

I make loaddata, doesn't it do the same thing? I'll test it again and see.

Still fails @KhadijaMahanga.

When data is missing, I usually get list index out of range. The min() args is an empty sequence is different. If memory serves me correctly, I've only seen this after starting to use Datasets & Releases