search

CodeForAfrica / sensors.AFRICA-api

The sensors.AFRICA API receiving, storing, and processing data received from sensors across the continentent. Accessible at https://api.sensors.africa/
https://api.sensors.africa/
18 stars 7 forks source link

Refactor apps to one sensorsafrica sensors app #21

Closed karimkawambwa closed 5 years ago

karimkawambwa commented 5 years ago

Description

This addresses MERGED PR:

  1. Cohesion: Can a part live outside the whole i.e. does it make sense to use sensors or accounts without using the whole API? If I can't think of any context where I'd use the "app" by itself then I don't write it as an app.

This is a very good point. I am going to merge this however, I will rethink this and if there is any other change, it will live in another refactor.

Instead of having multiple applications, this moves everything to live under one application.

karimkawambwa commented 5 years ago

@kilemensi 👀

kilemensi commented 5 years ago

Looks OK @karimkawambwa ... But now that you've added versioned to the mix, I'm not sure what base and versioned actually add to the mix.

Why not just sensorsafrica/{v1/,v2/,v3/} or sensorsafrica/api/{v1/,v2/,v3/} etc?

karimkawambwa commented 5 years ago

After our talk I think we have come to an understanding. I'll merge once tests pass 🚀