CodeForAfrica / sensors.AFRICA-api

The sensors.AFRICA API receiving, storing, and processing data received from sensors across the continentent. Accessible at https://api.sensors.africa/
https://api.sensors.africa/
18 stars 7 forks source link

Ft locations endpoint #75

Closed esirK closed 3 years ago

esirK commented 3 years ago

Description

Adds an endpoint allowing users to create sensors location

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Screenshots

Screenshot 2020-12-11 at 12 13 13 Screenshot 2020-12-11 at 12 15 59

Checklist:

esirK commented 3 years ago

👍🏾 @esirK

From quick review I think pagination is missing (and double check https://github.com/opendata-stuttgart/feinstaub-api/blob/master/feinstaub/sensors/views.py to see if we're missing anything else).

But overall I think what we need is authentication support: All these new APIs we're adding need to be protected and hence may be we should tackle that first.

We do have token authentication for this endpoint @kilemensi Here https://github.com/CodeForAfrica/sensors.AFRICA-api/pull/75/files#diff-2f87998a657738686f575e448d5d877f3fe958d836ac66174b3679424c86bd93R281